Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOVED] Remove staking controller account logic from pallets & runtimes #4574

Closed
wants to merge 77 commits into from

Conversation

rossbulat
Copy link

@rossbulat rossbulat commented May 25, 2024

Moved to #5449

@rossbulat rossbulat added I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet. D2-substantial Can be fixed by an experienced coder with a working knowledge of the codebase. labels May 25, 2024
Ross Bulat added 2 commits May 25, 2024 14:33
@rossbulat rossbulat changed the title [WIP]: Remove controller logic from staking pallet [WIP]: Remove staking controller account logic from pallets & runtimes May 27, 2024
@rossbulat rossbulat changed the title [WIP]: Remove staking controller account logic from pallets & runtimes Remove staking controller account logic from pallets & runtimes May 27, 2024
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6524317

@bkchr
Copy link
Member

bkchr commented Aug 15, 2024

@Ank4n will you take this over?

@rossbulat
Copy link
Author

@Ank4n will you take this over?

@bkchr actually I want to continue this with my fellowship work. Please can you ask the author prior to other contributors.

@bkchr
Copy link
Member

bkchr commented Aug 15, 2024

@Ank4n will you take this over?

@bkchr actually I want to continue this with my fellowship work. Please can you ask the author prior to other contributors.

For the last pr you just said that you can not continue because you are not inside the org. I expected the same applies here, but if you want to finish this, I don't care.

@rossbulat
Copy link
Author

@Ank4n will you take this over?

@bkchr actually I want to continue this with my fellowship work. Please can you ask the author prior to other contributors.

For the last pr you just said that you can not continue because you are not inside the org. I expected the same applies here, but if you want to finish this, I don't care.

Apologies for the confusion. Yes, currently in the process of re-structuring my workload so I will need to re-open this from a fork.

@rossbulat rossbulat changed the title Remove staking controller account logic from pallets & runtimes [MOVED] Remove staking controller account logic from pallets & runtimes Aug 23, 2024
@rossbulat rossbulat closed this Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D2-substantial Can be fixed by an experienced coder with a working knowledge of the codebase. I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants