Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zombienet-bridges-0001-asset-transfer-works #4069

Merged
merged 6 commits into from
Apr 13, 2024
Merged

Fix zombienet-bridges-0001-asset-transfer-works #4069

merged 6 commits into from
Apr 13, 2024

Conversation

serban300
Copy link
Contributor

Fixes #3999

@serban300 serban300 self-assigned this Apr 10, 2024
@serban300 serban300 force-pushed the bridge-zombienet-small-fixes branch from 9f3eac9 to 2195557 Compare April 10, 2024 14:29
@paritytech-review-bot paritytech-review-bot bot requested a review from a team April 10, 2024 14:29
@serban300 serban300 added R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges. labels Apr 10, 2024
@acatangiu acatangiu enabled auto-merge April 10, 2024 14:54
@serban300 serban300 disabled auto-merge April 10, 2024 14:58
@serban300
Copy link
Contributor Author

The test is still failing. Will convert this to draft for the moment and continue investigating.

@serban300 serban300 marked this pull request as draft April 10, 2024 15:03
@serban300 serban300 force-pushed the bridge-zombienet-small-fixes branch 5 times, most recently from fddd6ac to a83dc2e Compare April 11, 2024 14:13
@serban300 serban300 marked this pull request as ready for review April 11, 2024 15:34
@serban300 serban300 force-pushed the bridge-zombienet-small-fixes branch from a83dc2e to 43d2f67 Compare April 11, 2024 15:36
@serban300
Copy link
Contributor Author

Made call_polkadot_js_api synchroneous and now it seems to work. Ran the test > 5 times and it always succeeded. I will merge this fix.

@serban300 serban300 added this pull request to the merge queue Apr 12, 2024
@serban300 serban300 removed this pull request from the merge queue due to a manual request Apr 12, 2024
@serban300 serban300 force-pushed the bridge-zombienet-small-fixes branch from 43d2f67 to 6139950 Compare April 12, 2024 06:59
@serban300 serban300 added this pull request to the merge queue Apr 12, 2024
@serban300 serban300 removed this pull request from the merge queue due to a manual request Apr 12, 2024
@serban300 serban300 added this pull request to the merge queue Apr 12, 2024
@serban300 serban300 mentioned this pull request Apr 12, 2024
Closed
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 12, 2024
@serban300 serban300 added this pull request to the merge queue Apr 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 12, 2024
@bkontur bkontur enabled auto-merge April 12, 2024 19:47
@bkontur bkontur added this pull request to the merge queue Apr 13, 2024
Merged via the queue into paritytech:master with commit 8220c98 Apr 13, 2024
131 of 135 checks passed
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkontur bkontur bkontur approved these changes

Assignees

@serban300 serban300

Labels
R0-silent Changes should not be mentioned in any release notes T10-tests This PR/Issue is related to tests. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zombienet-bridges-0001-asset-transfer-works failures
3 participants
@serban300 @bkontur @acatangiu