rpc-v2/transaction: Generate Invalid events and add tests
#3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
niklasad1
reviewed
Apr 2, 2024
| self.client.info() | ||
| let mut info = self.client.info(); | ||
|
|
||
| if let Some((block_hash, block_num)) = self.best_block.lock().take() { |
There was a problem hiding this comment.
This lock().take() is a little hard read/reason about but since it's only for tests that is fine.
niklasad1
reviewed
Apr 2, 2024
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
bkchr
approved these changes
Apr 3, 2024
niklasad1
approved these changes
Apr 4, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the transaction API generates an
Invalidevents for transaction bytes that fail to decode.The spec mentioned the
Invalidevent at the jsonrpc error section, however this spec PR makes things clearer:While at it have discovered an inconsistency with the generated events. The drop event from the transaction pool was incorrectly mapped to the
invalidevent.Added tests for the API stabilize the API soon:
transactionWatchto version 1 json-rpc-interface-spec#144Closes: #3083
cc @paritytech/subxt-team