Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contracts: Remove unstable on lock/unlock_delegate_dependency host fns #3606

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Contracts: Remove unstable on lock/unlock_delegate_dependency host fns #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57a3264
remove unstable on lock/unlock_delegate_dependency host fns
pgherveou Mar 7, 2024
f7534bc
Mark lock/unlock as stable
pgherveou Mar 7, 2024
9e95953
fix prdoc
pgherveou Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions prdoc/pr_3606.prdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
title: "[pallet_contracts] mark lock/unlock_delegate_dependency as stable"

doc:
- audience: Runtime Dev
description: |
Lock and unlock delegate dependency are stable now, so we can mark them as such.

crates:
- name: pallet-contracts
2 changes: 0 additions & 2 deletions substrate/frame/contracts/src/wasm/runtime.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2305,7 +2305,6 @@ pub mod env {

/// Adds a new delegate dependency to the contract.
/// See [`pallet_contracts_uapi::HostFn::lock_delegate_dependency`].
#[unstable]
fn lock_delegate_dependency(ctx: _, memory: _, code_hash_ptr: u32) -> Result<(), TrapReason> {
ctx.charge_gas(RuntimeCosts::LockDelegateDependency)?;
let code_hash = ctx.read_sandbox_memory_as(memory, code_hash_ptr)?;
Expand All @@ -2315,7 +2314,6 @@ pub mod env {

/// Removes the delegate dependency from the contract.
/// see [`pallet_contracts_uapi::HostFn::unlock_delegate_dependency`].
#[unstable]
fn unlock_delegate_dependency(ctx: _, memory: _, code_hash_ptr: u32) -> Result<(), TrapReason> {
ctx.charge_gas(RuntimeCosts::UnlockDelegateDependency)?;
let code_hash = ctx.read_sandbox_memory_as(memory, code_hash_ptr)?;
Expand Down
Loading