-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime: allow backing multiple candidates of same parachain on different cores #3231
Merged
Merged
Changes from 1 commit
Commits
Show all changes
63 commits
Select commit
Hold shift + click to select a range
cab6ab9
Switch statement table from ParaId to CoreIndex
sandreim d2df658
cargo lock
sandreim 4a8b8d5
add experimental feature
sandreim 9244632
inject core_index from statements
sandreim 22e017b
temporary provisioner fix
sandreim 9dc8927
Support injected `CoreIndex`
sandreim 574b06a
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
sandreim fbb7351
cargo lock
sandreim c6b833e
Merge branch 'sandreim/backing_multiple_cores_per_para' of github.com…
sandreim 6c72918
It was damn hard to fix these tests
sandreim fc5c109
These tests were easy to fix
sandreim 33351b4
Fix comment
sandreim 0d994bf
clippy was angry
sandreim 534c019
A bit refactor and add a test
sandreim 10d86dd
taplo happy
sandreim d990a65
Merge branch 'sandreim/backing_multiple_cores_per_para' of github.com…
sandreim fbe1ad5
BackedCandidate: make all members private and provide an interface
sandreim e74f038
refactor based on new BackedCandidate
sandreim d898740
Fix all parachain runtime tests affected
sandreim 9e40490
fix more broken test on node side
sandreim 42f46a0
wip new test
sandreim 222609c
review feedback
sandreim 532d363
Merge branch 'sandreim/backing_multiple_cores_per_para' of github.com…
sandreim ccb2a88
ElasticScalingCoreIndex
sandreim a5ba157
finish filtering of candidates for elastic scaling
sandreim a02e896
remove log
sandreim dd34850
more feedback
sandreim 838a846
Merge remote-tracking branch 'origin/master' into sandreim/backing_mu…
alindima ad98f18
use next up on available instead of occupied core index
alindima 606d7c4
ElasticScalingCoreIndex -> ElasticScalingMVP
alindima 6fb6b73
Merge remote-tracking branch 'origin/sandreim/backing_multiple_cores_…
alindima 10f6486
rename ElasticScalingCoreIndex
alindima f9e178d
address some comments
alindima ec7b660
+1
alindima 578850b
more comments
alindima 362ff1e
add a backing test
alindima 2385369
add rstest
alindima c793b89
small nits and typos
alindima 8398bb1
Merge remote-tracking branch 'origin/master' into sandreim/backing_mu…
alindima 27ec25b
Merge remote-tracking branch 'origin/sandreim/backing_multiple_cores_…
alindima 9f70276
Merge remote-tracking branch 'origin/master' into sandreim/backing_mu…
alindima 19c9a67
review comments
alindima d7b6ce8
add zombienet test
alindima afed2a8
fix existing unit tests
alindima 7ea040d
add prdoc
alindima 79f281b
fix clippy
alindima 7521ed9
try fixing prdoc
alindima 9c3dd5c
cache Validator->Group mapping
alindima 0b0b6d1
Merge remote-tracking branch 'origin/sandreim/backing_multiple_cores_…
alindima 7976e2f
lockfile
alindima 4d6e797
add tests for backedcandidate functions
alindima 4c36440
newlines
alindima af1cd82
use Arc to avoid cloning
alindima 5cc5b8b
Merge branch 'sandreim/backing_multiple_cores_per_para' into sandreim…
alindima dc57adb
add check for parachain stall to zombienet test
alindima bb5968c
add more unit tests
alindima 1ca7a70
Merge remote-tracking branch 'origin/master' into sandreim/runtime_co…
alindima eb345b0
fix clippy
alindima 058c0c2
refactor
alindima d4c58bd
fix some bugs and add more unit tests
alindima cb41758
update some comments
alindima bffa4e9
review comments
alindima 5d3a85d
fix unit test
alindima File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
finish filtering of candidates for elastic scaling
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
- Loading branch information
commit a5ba15722208e0aeeeff3ca0dd161bedc31a8b1d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sense? If we want to check for this feature at all in the runtime then we should only use it in validation: Reject any candidate that has superfluous bits if not set, but I don't really see value in that either. If provided, we might as well use it, instead of being stubborn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I generally agree with you, but I think it's a chicken-and-egg situation. In order to know if we have the core index encoded in the validator_indices, we need to know the backing group size. In order to know the backing group, we need to know the core index