rpc: add rpc v2 chainSpec to polkadot
#2859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpc v2 chainSpec to polkadot and cumulusrpc v2 chainSpec to polkadot
bkchr
approved these changes
Jan 6, 2024
skunert
approved these changes
Jan 8, 2024
polkadot/rpc/src/lib.rs
Outdated
| @@ -99,6 +99,7 @@ pub fn create_full<C, P, SC, B>( | |||
| ) -> Result<RpcExtension, Box<dyn std::error::Error + Send + Sync>> | |||
| where | |||
| C: ProvideRuntimeApi<Block> | |||
| + sc_client_api::BlockBackend<Block> | |||
There was a problem hiding this comment.
nit: I think we don't need this if you use the hash method from HeaderBackend
…hains' into na-add-chainspec-v2-api-to-all-chains
lexnv
approved these changes
Jan 8, 2024
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
The [chainSpec RPC API from the v2 spec](https://paritytech.github.io/json-rpc-interface-spec/api/chainSpec.html) was only added to substrate-node and should be added to polkadot as well /cc @lexnv
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* if bundled version is `None` and cli said "use bundled" => error * update chain spec and transaction versions * use generated runtime wrapper for PBH and KBH * trigger CI * Revert "trigger CI" This reverts commit 7d9f51e34829d9224b352300d062e365243def5e. * Revert "Revert "trigger CI"" This reverts commit c86ca0e264367e39abad29b9f09f09578a980568. * Revert "Revert "Revert "trigger CI""" This reverts commit 95e7da258bb2ace4ed2cafdb01833317f38cfcfc.
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The chainSpec RPC API from the v2 spec was only added to substrate-node and should be added to polkadot as well
/cc @lexnv