Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref docs: runtime vs contracts #2609
Ref docs: runtime vs contracts #2609
Changes from 19 commits
a797f45
67c0078
6f33cd6
75738cf
14b7132
f869f8c
07beabb
c9ed2ee
a60b228
866676d
0879cba
dd8ea70
17c8d11
c0676a5
83980de
fa97cca
81762e4
71d17ea
911d8a1
6d37a22
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have had numerous rants about the misuse of the word "DApp" in this space. So, I want to ask the author, what do you mean by DApp throughout this page?
Specifically, let's look at https://apps.acala.network/. Is this a DApp? Bear in mind that this page is purely interacting with a blockchain runtime, no smart contracts.
Once we conclude this discussion, it would be good to update the glossary as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bit late, and already resolved on another conversation.
But would love to drop my opinion here anyway.
As I see it DApps are applications with their logic in a decentralized and distributed system, for instance a blockchain. Whether this logic is part of a runtime or a smart contract doesn't play a differentiating role to me.
I'd argue https://staking.polkadot.network/ is a great DApp in the Polkadot ecosystem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to mention ink! https://use.ink/ as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ink! lives within the WASM-based contracts, I wanted to keep this document agnostic to the actual smart contract language
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: a diagram here that shows a substrate based chain, hosting
pallet-evm
, which itself is hosting a number of Solidity contracts. Should clearly show that by uploading/executing a new contract, you are not programming the blockchain itself. The blockchain is constant, smart contracts are being programmed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then a counterpart diagram here that shows that in the Runtime development model, you are programming the blockchain itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could pass the point across here with an image? I remember in PBA to have seen this analogy of the cartridge and the console for the host vs runtime and how that architecture enabled upgradeability. Maybe we could get a similar one here for Runtime vs Smart contracts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give concrete implications of getting the weight of a transaction incorrect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the "vulnerability exploitation" part is very important