Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statement-distribution: validator disabling #1841

Merged
merged 13 commits into from
Jan 10, 2024
8 changes: 8 additions & 0 deletions .gitlab/pipeline/zombienet/polkadot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,14 @@ zombienet-polkadot-functional-0009-approval-voting-coalescing:
--local-dir="${LOCAL_DIR}/functional"
--test="0009-approval-voting-coalescing.zndsl"

zombienet-polkadot-functional-0010-validator-disabling:
extends:
- .zombienet-polkadot-common
script:
- /home/nonroot/zombie-net/scripts/ci/run-test-local-env-manager.sh
--local-dir="${LOCAL_DIR}/functional"
--test="0010-validator-disabling.zndsl"

zombienet-polkadot-smoke-0001-parachains-smoke-test:
extends:
- .zombienet-polkadot-common
Expand Down
3 changes: 3 additions & 0 deletions polkadot/node/network/statement-distribution/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ pub enum Error {
#[error("Fetching availability cores failed {0:?}")]
FetchAvailabilityCores(RuntimeApiError),

#[error("Fetching disabled validators failed {0:?}")]
FetchDisabledValidators(runtime::Error),

#[error("Fetching validator groups failed {0:?}")]
FetchValidatorGroups(RuntimeApiError),

Expand Down
4 changes: 3 additions & 1 deletion polkadot/node/network/statement-distribution/src/v2/grid.rs
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,9 @@ impl GridTracker {
/// This checks whether the peer is allowed to send us manifests
/// about this group at this relay-parent. This also does sanity
/// checks on the format of the manifest and the amount of votes
/// it contains. It has effects on the stored state only when successful.
/// it contains. It assumes that the votes from disabled validators
/// are already filtered out.
/// It has effects on the stored state only when successful.
///
/// This returns a `bool` on success, which if true indicates that an acknowledgement is
/// to be sent in response to the received manifest. This only occurs when the
Expand Down
Loading