Cleanup deprecated apis #1764
Cleanup deprecated apis #1764
Conversation
| @@ -254,11 +120,7 @@ pub fn put_storage_value<T: Encode>(module: &[u8], item: &[u8], hash: &[u8], val | |||
| /// `hash`. | |||
| #[deprecated = "Use `clear_storage_prefix` instead"] | |||
There was a problem hiding this comment.
Can you also add a deprecation string here in the same format as above with a fixed date please?
There was a problem hiding this comment.
I guess that can also be deleted, as even if it didn't have the deprecation date noted is already 16 months old
There was a problem hiding this comment.
This needs a prdoc https://github.com/paritytech/polkadot-sdk/blob/master/docs/CONTRIBUTING.md#documentation
Looping in @sacha-l and @Rashmirreddy for potential communication and documentation.
There was a problem hiding this comment.
Won't block this, but won't approve as-is either to suggest this guideline for these PRs:
- In the PR description, make a list of items you are removing
- Link to the PR merge date when they got merged, and approximately which release they went into.
Hopefully this is not too much work, but it gives us a very yardstick to know what we are deleting.
All in all though, there is a lot of such code in the codebase. Thanks for attending to them!
|
Ok, maybe should be closed. I do not know the detail processes about deprecating apis. |
Clean up some deprecated apis for pallets :
Polkadot address: yjhmelody