Update smoldot, improve chainspec loading error message #1581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalkucharczyk
approved these changes
Sep 15, 2023
davxy
approved these changes
Sep 15, 2023
bkchr
reviewed
Sep 17, 2023
lexnv
approved these changes
Sep 18, 2023
|
This job seems more flaky than before: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3740251, I will hold off merging for now. |
bkchr
approved these changes
Sep 25, 2023
| #[derive(Debug, serde::Deserialize)] | ||
| struct EmptyChainSpecWithId { | ||
| id: String, | ||
| } | ||
|
|
||
| let file = std::fs::File::open(self).expect("Failed to open file"); | ||
| let file = std::fs::File::open(self)?; | ||
|
|
||
| let reader = std::io::BufReader::new(file); | ||
| let chain_spec: EmptyChainSpecWithId = serde_json::from_reader(reader) | ||
| .expect("Failed to read 'json' file with ChainSpec configuration"); |
There was a problem hiding this comment.
this failure also could be returned with '?'
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
polkadot-parachain.