Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant book keeping in dispute coordinator. #1432

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Remove redundant book keeping in dispute coordinator. #1432

merged 2 commits into from
Sep 11, 2023

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Sep 6, 2023 •
edited by Overkillus
Loading

With the introduction of Inclusions in scraper we had redundant book keeping of included candidates. Once with information needed for reversions and once without. This PR removes this unnecessary redundancy.

@Overkillus If you could add tests for Inclusions, that'd be great, in particular:

  • Pruning of a candidate that was added at the same height works as expected - with same relay parent hash and with different.
  • Pruning of inclusion works as expected even if the candidate has been included at different heights.
  • Basic state checks after insertions
  • Other corner cases you can think of.

@eskimor eskimor added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Sep 6, 2023
BradleyOlson64
BradleyOlson64 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@BradleyOlson64 BradleyOlson64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely like how this moves all the inclusion pruning into a single inclusions.remove_up_to_height call. 👍

@eskimor eskimor enabled auto-merge (squash) September 11, 2023 08:30
@eskimor eskimor merged commit 5b3f659 into master Sep 11, 2023
@eskimor eskimor deleted the rk-scraping-cleanup branch September 11, 2023 09:25
Daanvdplas pushed a commit that referenced this pull request Sep 11, 2023
@eskimor @Daanvdplas
Remove redundant book keeping in dispute coordinator. (#1432)
03eb98a 
* Remove redundant book keeping in dispute coordinator.

* Fix docs.

---------

Co-authored-by: eskimor <eskimor@no-such-url.com>
@Overkillus Overkillus mentioned this pull request Sep 12, 2023
Merged
Overkillus added a commit that referenced this pull request Sep 13, 2023
@Overkillus
Inclusions struct unit tests (#1518)
f7c95c5 
In follow-up to #1432

Some additional unit tests for the inclusion struct used in the scraper.
@kiltbot kiltbot mentioned this pull request Oct 19, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@svyatonik @bkchr
Added tracked parachains filter (#1432)
5340ee5 
* added trackerd parachains filter + changed some docs

* fix compilation
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BradleyOlson64 BradleyOlson64 BradleyOlson64 approved these changes

@tdimitrov tdimitrov tdimitrov approved these changes

@ordian ordian Awaiting requested review from ordian

@Overkillus Overkillus Awaiting requested review from Overkillus

Assignees
No one assigned
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eskimor @tdimitrov @BradleyOlson64