Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Assets Pallet's Privileged Roles Option #91

Open
joepetrowski opened this issue Oct 10, 2022 · 7 comments
Open

Make Assets Pallet's Privileged Roles Option #91

joepetrowski opened this issue Oct 10, 2022 · 7 comments
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@joepetrowski
Copy link
Contributor

joepetrowski commented Oct 10, 2022 •
edited
Loading

Change the privileged asset roles from AccountId to Option<AccountId>. When the owner is set to None, only governance would be able to restore the role.

For discussion, if owner is Some, and they want to set a lower rank role from None to Some, should that require governance?

This would look similar to the PoolRoles struct in Nomination Pools.

Originally posted by @joepetrowski in paritytech/substrate#12310 (comment)
@joepetrowski joepetrowski changed the title Make Assets Pallet Privileges Option Make Assets Pallet's Privileged Roles Option Oct 10, 2022
@dharjeezy
Copy link
Contributor

dharjeezy commented Oct 28, 2022 •
edited
Loading

I see this issue is not solved yet. Can i go ahead to open a PR for it?
@joepetrowski @vieira-giulia

@vieira-giulia
Copy link

vieira-giulia commented Oct 28, 2022 •
edited
Loading

@dharjeezy
Hey, yea I do have a branch for it, figuring out what this implies in the rest of the pallet and tests, just having some problems with my computer to run things.
Anyway, I remember hearing you talk you already had this change implemented for another reason in another branch so if you just want to open a PR that's fine for me

@Polkadot-Forum
Copy link

This issue has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/preventing-attacks-on-xcm-reserves/902/5

@dharjeezy dharjeezy mentioned this issue Oct 28, 2022
Closed
@dharjeezy
Copy link
Contributor

@dharjeezy Hey, yea I do have a branch for it, figuring out what this implies in the rest of the pallet and tests, just having some problems with my computer to run things. Anyway, I remember hearing you talk you already had this change implemented for another reason in another branch so if you just want to open a PR that's fine for me

Alright @vieira-giulia i have gone ahead to open the PR

@muharem
Copy link
Contributor

muharem commented May 11, 2023 •
edited
Loading

could be also enum, {Root, Account(who)}, which can be extended later if needed

@joepetrowski joepetrowski transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed J0-enhancement labels Aug 25, 2023
lexnv added a commit that referenced this issue Apr 3, 2024
@tomaka @lexnv @josepot
Add sudo_network_unstable_watch (#91)
607b71b 
* Add `sudo_network_unstable_watch`

* Hyperlink in SUMMARY

* Update src/api/sudo_network_unstable_watch.md

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>

* Update src/api/sudo_network_unstable_watch.md

Co-authored-by: Josep M Sobrepere <jm.sobrepere@gmail.com>

---------

Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
Co-authored-by: Josep M Sobrepere <jm.sobrepere@gmail.com>
@gui1117
Copy link
Contributor

gui1117 commented Apr 4, 2024

Removing ownership priviledge is a common practice in some coin like meme coin for instance.

  • PINK token recently revoke ownership by using a trick: move ownership to pure proxy and kill the proxy.
    This is a bit like inscription, prooving an ownership has been revoked is not light-client friendly
  • solana TOKEN 2022 contract has a function revoke freeze and mint. (and metadata?)

Actually I am only interested in a feature to revoke every priviledge, I feel like revoking only mint, or only freezer, or only admin is not really useful.

2 implementation:

  • fine grained: make Owner, Freezer, Issuer, Admin an option and add some call to revoke them individually
    it is a breaking change, needs migration, frontend will have to update a bit.
  • Easy implementation: make a new asset status: LiveAndNotOwned.
    doesn't break the storage, frontend only needs to handle this new status.

@joepetrowski
Copy link
Contributor Author

Good point about the easy implementation, None roles for anyone but the owner is kind of meaningless. I would maybe go for something more like LiveAndLocked as a status.

jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@svyatonik @tomusdrw
@HCastano @bkchr
Claim funds on Substrate chain by providing proof of funds locking on…
7294ea4 
… PoA chain (paritytech#91)

* ethereum exchange module

* continue

* continue

* added tests for exchange module

* moved

* remove println

* move again

* fixes

* removed redundant deps

* cargo fmt

* fund_locks_transaction_decode_works

* cargo fmt --all

* fix error processing

* added some tracing to bridge modules

* more tests

* more tests

* cargo fmt --all

* kovan.rs -> exchange.rs

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* added assumption doc

* Airdrop -> DepositInto

* AsIs -> Identity

* OnTransactionSubmitted

* Transfers::Key = Id

* typo

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* block+tx+proof -> proof { block, tx, proof }

* cargo fmt --all

* docs

* check <-> verify

* parse hex

* extracted exchange primitives to separate crate

* added docs to runtime::exchange module

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* typo

* Update modules/currency-exchange/Cargo.toml

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* add docs to currency-exchange module

* change tests names

* cargo fmt --all

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Update bin/node/runtime/src/exchange.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* fixed verify_transaction_finalized for siblings of finalized blocks

* cargo fmt --all

* added double spend note

* cargo fmt --all

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C1-mentor A task where a mentor is available. Please indicate in the issue who the mentor could be. I5-enhancement An additional feature request. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Runtime / FRAME
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Assets Pallet's Privileged Roles Option dharjeezy/substrate
8 participants
@juangirini @muharem @gui1117 @dharjeezy @joepetrowski @vieira-giulia @the-right-joyce @Polkadot-Forum