Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore .local dns addresses from global DHT #545

Open
jordy25519 opened this issue Nov 20, 2020 · 2 comments
Open

Ignore .local dns addresses from global DHT #545

jordy25519 opened this issue Nov 20, 2020 · 2 comments

Comments

@jordy25519
Copy link

jordy25519 commented Nov 20, 2020 •
edited
Loading

Is it possible the Kademlia DHT can be filled with .local addresses from the likes of kubernetes clusters?
or will they be removed automatically by failed connection attempts etc.?

https://github.com/paritytech/substrate/blob/f74de63d23214b530ac24ac3ea4ead1180e22e83/client/network/src/discovery.rs#L396-L397
@bkchr
Copy link
Member

bkchr commented Nov 20, 2020

Cc @tomaka

@tomaka
Copy link
Contributor

tomaka commented Nov 20, 2020

Multiaddresses in general are indeed removed from the k-buckets if we fail to connect to them.

Multiaddresses are added only at initialization, or if a node reports that it's listening on this address.
Nodes never report that they're listening on a domain name, unless you pass this domain name with --public-addr.

In other words, the only way to somehow insert a domain name in the DHT is to pass it manually using --bootnodes, --reserved-nodes or --public-addr.

@altonen altonen transferred this issue from paritytech/substrate Aug 24, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@sumitsnk
SNO-142 ETHApp.sol: should not use transfer() for transferring Ether (p…
dd9ed6c 
…aritytech#545)

* Replaced transfer with call

* Removed ReentrancyGuard
bkchr pushed a commit that referenced this issue Apr 10, 2024
@svyatonik @tomusdrw
@HCastano @bkchr
Limit max number of unconfirmed messages at inbound lane (#545)
2944f99 
* limit maximal number of unconfirmed messages at inbound lane

* unrewarded_relayer_entries API

* change relay to support max unrewarded relayer entries

* Update modules/message-lane/src/inbound_lane.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* Update relays/messages-relay/src/message_lane_loop.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* removed pub

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Networking
Status: Backlog 🗒
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tomaka @jordy25519 @bkchr @altonen @the-right-joyce