Merge Protocol
and Notifications
#516
Labels
D1-medium
Can be fixed by a coder with good Rust knowledge but little knowledge of the codebase.
I4-refactor
Code needs refactoring.
I9-optimisation
An enhancement to provide better overall performance in terms of time-to-completion for a task.
After paritytech/substrate#12828,
Protocol
has no role in the networking stack anymore as the syncing protocol now lives abovesc-network
and the low-level API used for sync is no longer used. Notification-related events can be sent directly fromNotifications
.Tasks:
HARDCODED_PEERSET_SYNC
and all functionality that references the hardcodedPeerset
entryadd_peers_to_set
anddisconnect_peer
forNotifications
block_announce_config
fromParams
insrc/config.rs
and treat it instead as any otherNotifications
protocol[1] "By coincidence", paritytech/substrate#12441 converted the default empty handshake to send the role of the node as the default handshake. This means that each protocol now has the capability of learning the role of remote peer by decoding the handshake, meaning that this logic can be moved out of
Protocol
and theBlockAnnouncesHandshake
decoding can also moved toSyncingEngine
.The text was updated successfully, but these errors were encountered: