Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking/session: Rename the interactions #467

Open
kianenigma opened this issue Dec 16, 2020 · 5 comments
Open

Staking/session: Rename the interactions #467

kianenigma opened this issue Dec 16, 2020 · 5 comments
Assignees
Labels
I5-enhancement An additional feature request.

Comments

@kianenigma
Copy link
Contributor

kianenigma commented Dec 16, 2020

The naming of the interactions between session and staking is a bit confusing. Here's a proposal from a different discussion with @thiolliere:

new_session -> schedule_session
start_session -> activate_session
current_era -> scheduled_era
active_era -> active_era
ErasStartSessionIndex -> ActiveErasStartSessionIndex

Will sadly need a runtime migration though.

@kianenigma kianenigma changed the title Staking/session: Rename the interaction Staking/session: Rename the interactions Dec 16, 2020
@gui1117
Copy link
Contributor

gui1117 commented Dec 17, 2020

current_era -> scheduled_era

maybe better latest_scheduled_era. because there can be multiple era scheduled ahead of the active_era.

ErasStartSessionIndex -> ScheduledErasStartSessionIndex

Note that currently this storage holds the information for all eras in latest_scheduled_era - HISTORY_DEPTH to latest_scheduled_era.
Thus it also contains the information active_era and below. Though I think we don't use it so maybe we could clear this storage when era is activated.

@gui1117
Copy link
Contributor

gui1117 commented Mar 2, 2021

We can also rename EstimateNextNewSession to EstimateNextScheduleSession

@stale
Copy link

stale bot commented Jul 7, 2021

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale label Jul 7, 2021
@gui1117
Copy link
Contributor

gui1117 commented Jul 8, 2021

I still think we should do that

@stale stale bot removed the A5-stale label Jul 8, 2021
@kianenigma kianenigma self-assigned this Jul 8, 2021
@michalisFr
Copy link

Since current_era (or scheduled_era) affects many aspects of staking, including when the unbonding period ends, can we add the start timestamp in chain state, similarly to active_era?

Screenshot 2023-02-21 at 3 59 47 PM

@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed J0-enhancement labels Aug 25, 2023
claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
* make libsecp256k1 a dev dependency

* resolver version 2
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
* update Millau state_root

* update jsonrpsee reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request.
Projects
Status: ⌛️ Sometime-soon
Development

No branches or pull requests

4 participants