-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench/cli: extend --extrinsic
name filtering
#401
Comments
@ggwpez attempted this issue, kindly look at my solution in the PR. |
paritytech/substrate#10677 implemented the list part, leaving this issue open since the regex could still be relevant. |
Hello @ggwpez what is the regex supposed to specifically do asides from the comma separation that the other PR did? |
It would allow for more advanced filtering. But the list approach is good enough for now, just wanted to keep track of it. |
Alright @ggwpez when you ascertain what the advance filtering would be then i am willing to pick it up and implement so as to close out this issue. |
* Add Rialto as a target for the Millau node * Rename Rialto module to Rialto-PoA This will reduce confusion as the Millau runtime has a Rialto module as well which refers to the Substrate chain. * Add Millau as a target for the Rialto node * Be more explicit about Rialto PoA related code * Missed some name changes in the Ethereum PoA relay * Re-export Substrate pallet structs used by node * Remove `first_scheduled_change` of Millau in Rialto node * Make Millau's genesis config for Rialto bridge more accurate * Set initial header for Millau config * Update initial Millau authorities Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com> * RustFmt Millau authorities Co-authored-by: Svyatoslav Nikolsky <svyatonik@gmail.com>
Current Situation
The
bench-cli
cannot be instructed to run more than one specific case per pallet.This would be useful to have when trying to debug specific cases where others take really long to run, eg. in paritytech/substrate#10644.
Proposed Change
Make
--extrinsic
accept a comma separated list (done in paritytech/substrate#10677) or a regex such thatext1, ext2
orext1|ext2
resp. would be valid.A more advanced version could even allow filtering the whole
"pallet.case"
string for cross-pallet selection.The text was updated successfully, but these errors were encountered: