Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic scaling: make sure to preserve candidate ordering in GetBackedCandidates #3742

Closed
alindima opened this issue Mar 19, 2024 · 0 comments · Fixed by #3778
Closed

Elastic scaling: make sure to preserve candidate ordering in GetBackedCandidates #3742

alindima opened this issue Mar 19, 2024 · 0 comments · Fixed by #3778
Assignees
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.

Comments

@alindima
Copy link
Contributor

Here:

fn handle_get_backed_candidates_message(

We need to trim all candidates of the paraid that follow a candidate for which we couldn't retrieve its data. Otherwise, we may end up supplying invalid chains to the runtime. The runtime should trim this for us, but it'd be better to not supply invalid chains to the runtime in the first place

We can also double check this in the provisioner after we get a response

@alindima alindima added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Mar 19, 2024
@alindima alindima self-assigned this Mar 19, 2024
@alindima alindima moved this from Backlog to In Progress in parachains team board Mar 20, 2024
@alindima alindima linked a pull request Mar 21, 2024 that will close this issue
@alindima alindima moved this from In Progress to Review in progress in parachains team board Mar 25, 2024
@github-project-automation github-project-automation bot moved this from Review in progress to Completed in parachains team board Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T8-polkadot This PR/Issue is related to/affects the Polkadot network.
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

1 participant