Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate StorageValue key at compile time #372

Closed
bkchr opened this issue Apr 26, 2019 · 5 comments
Closed

Generate StorageValue key at compile time #372

bkchr opened this issue Apr 26, 2019 · 5 comments
Assignees
@ggwpez
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework.

Comments

@bkchr
Copy link
Member

bkchr commented Apr 26, 2019

For StorageValue we can hash the key at compile time and can omit this at runtime.
@bkchr bkchr added the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Apr 26, 2019
@gavofyork
Copy link
Member

This should be lower priority than paritytech/substrate#2400

@cheme cheme mentioned this issue May 31, 2019
Open
@shawntabrizi
Copy link
Member

cc @ggwpez

@ggwpez ggwpez self-assigned this Jun 15, 2022
@ggwpez ggwpez mentioned this issue Jul 21, 2022
Closed
@juangirini juangirini transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added T1-FRAME This PR/Issue is related to core FRAME, the framework. and removed T1-runtime labels Aug 25, 2023
@bkchr bkchr mentioned this issue Sep 13, 2023
Merged
@kianenigma
Copy link
Contributor

Closed in the above PR.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Runtime / FRAME Oct 15, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Benchmarking and Weights Oct 15, 2023
@liamaharon
Copy link
Contributor

@kianenigma did it really close it? This issue seems to ask for generalised compile time computation, where the above PR seemed to only do it for pallet storage key prefix

@bkchr
Copy link
Member Author

bkchr commented Oct 16, 2023

The pr is doing it for the pallet and storage key prefix. I think this is what I wanted in 2019 :P

claravanstaden pushed a commit to Snowfork/polkadot-sdk that referenced this issue Dec 8, 2023
@vgeddes
Fix default location of polkadot binary (paritytech#372)
c5e91a7
helin6 pushed a commit to boolnetwork/polkadot-sdk that referenced this issue Feb 5, 2024
@tgmichel
Pre-calculate Bloom (paritytech#372)
06de468
jonathanudd pushed a commit to jonathanudd/polkadot-sdk that referenced this issue Apr 10, 2024
@HCastano @bkchr
Split Rialto and Millau Nodes (paritytech#372)
8b8248f 
* Split the Rialto Node into a standalone crate

* Split the Millau Node into a standalone crate

* Remove `bridge-node` crate

* Add benchmarking feature to nodes

* Check that benchmarks compile in CI

* Remove nodes from CI matrix

* Update Rialto node to Substrate 2.0

* Get Millau node compiling with Substrate 2.0

* Remove extra license text

* Remove comments in TOML files

* Move nodes and runtimes into Rialto and Millau folders

* Fix dependency paths

* Remove unused script

* Add issue to benchmarking TODO

* Fix benchmark manifest paths
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggwpez ggwpez

Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Benchmarking and Weights
Status: Done
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

No branches or pull requests
8 participants
@gavofyork @shawntabrizi @juangirini @kianenigma @bkchr @ggwpez @liamaharon @the-right-joyce