Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
pgherveou authored Jan 10, 2025
1 parent 2b5675a commit 50232db
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion prdoc/pr_6689.prdoc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Previously, these three parameters were passed along with the signed payload, an

This approach unfortunately can be attacked. A malicious actor could force such a transaction to fail by injecting low values for some of these extra parameters as they are not part of the signed payload.

The new approach encodes these 3 extra parameters in the lower digits of the transaction gas, approximating the the log2 of the actual values to encode each components on 2 digits
The new approach encodes these 3 extra parameters in the lower digits of the transaction gas, using the log2 of the actual values to encode each components on 2 digits
crates:
- name: pallet-revive-eth-rpc
bump: minor
Expand Down

0 comments on commit 50232db

Please sign in to comment.