BREAKING CHANGE: DecodeLimit and DecodeAll extensions now advance input #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
previously requested changes
Feb 2, 2022
Oh. Checking my IDE and |
e49f1f3 to
e485f00
Compare
e485f00 to
703a899
Compare
bkchr
reviewed
Feb 2, 2022
You probably need to copy the rustfmt.toml file. You can add it here in the pr. |
|
This has been a rollercoaster, but hopefully everything is better than how it started. |
bkchr
approved these changes
Feb 3, 2022
bkchr
reviewed
Feb 3, 2022
|
@KiChjang Could you please have a second look on this? I would like to merge to master and release 3.0.0 |
Fixed whitespaces and asked further review on a smaller diff.
KiChjang
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #287
Fixes #313