Makes ValueTable::init_with_entry cleanly abort on error (#122)

src/file.rs

@@ -211,4 +211,13 @@ impl TableFile {
 		}
 		Ok(())
 	}
+
+	pub fn remove(&self) -> Result<()> {
+		let mut file = self.file.write();
+		if let Some(file) = file.take() {
+			drop(file);
+			try_io!(std::fs::remove_file(&self.path));
+		}
+		Ok(())
+	}
 }

src/table.rs

@@ -970,6 +970,15 @@ impl ValueTable {
 	}
 
 	pub fn init_with_entry(&self, entry: &[u8]) -> Result<()> {
+		if let Err(e) = self.do_init_with_entry(entry) {
+			log::error!(target: "parity-db", "Failure to initialize file {}", self.file.path.display());
+			let _ = self.file.remove(); // We ignore error here
+			return Err(e)
+		}
+		Ok(())
+	}
+
+	fn do_init_with_entry(&self, entry: &[u8]) -> Result<()> {
 		self.file.grow(self.entry_size)?;
 
 		let empty_overlays = parking_lot::RwLock::new(Default::default());