Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bounded-collections: Add Const(Int|Uint) for generic const getter support #878

Merged
merged 7 commits into from
Nov 4, 2024
Merged

bounded-collections: Add Const(Int|Uint) for generic const getter support #878

merged 7 commits into from
Nov 4, 2024

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Oct 24, 2024

Refer to: paritytech/polkadot-sdk#6193

This PR introduces ConstInt and ConstUint to support generic constant integer getter.

ordian
ordian approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Could you please update the changelog as well?

bounded-collections/src/lib.rs Outdated Show resolved Hide resolved
@ordian ordian requested a review from bkchr October 24, 2024 14:39
@conr2d conr2d mentioned this pull request Oct 29, 2024
Closed
gui1117
gui1117 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never thought about asserting const expression like this.

Very nice.

@gui1117
Copy link
Contributor

gui1117 commented Nov 4, 2024 •
edited
Loading

ideally we could ensure the compilation fail with trybuild.
fixed, thank you

bkchr
bkchr approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Did not know about this "late const assert evaluation"

bounded-collections/src/const_int.rs Outdated Show resolved Hide resolved
bounded-collections/src/const_int.rs Outdated Show resolved Hide resolved
bounded-collections/src/const_int.rs Outdated Show resolved Hide resolved
bounded-collections/src/const_int.rs Outdated Show resolved Hide resolved
bounded-collections/src/const_int.rs Outdated Show resolved Hide resolved
@ordian ordian merged commit 31ae234 into paritytech:master Nov 4, 2024
6 checks passed
@conr2d conr2d deleted the const-int branch November 5, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@bkchr bkchr bkchr approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@conr2d @gui1117 @ordian @bkchr