Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert libc removal #340

Closed
wants to merge 6 commits into from
Closed

revert libc removal #340

wants to merge 6 commits into from

Conversation

ordian
Copy link
Member

@ordian ordian commented Feb 10, 2020

@ordian ordian requested a review from NikVolf February 10, 2020 15:58
@ordian ordian mentioned this pull request Feb 10, 2020
Closed
NikVolf
NikVolf suggested changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@NikVolf NikVolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, I will make few more benchmarks to be sure on this

@dvdplm
Copy link
Contributor

dvdplm commented Feb 10, 2020

Hold on, I will make few more benchmarks to be sure on this

Let us know what you find out. :)

@dvdplm
Copy link
Contributor

dvdplm commented Feb 12, 2020

Ping @NikVolf

@NikVolf
Copy link
Contributor

NikVolf commented Feb 12, 2020

Hey I am still not confident with numbers

Is there any rush on this?

@dvdplm
Copy link
Contributor

dvdplm commented Feb 12, 2020

Is there any rush on this?

No rush at all, take your time.

@ordian
Merge branch 'master' into ao-revert-libc-removal
d651dcd 
* master:
  Update/change licenses: MIT/Apache2.0 (#342)
  rlp-derive extracted (#343)
  Format for readme and changelog corrected (#341)
  Parity runtime moved to parity common for publication in crates.io (#271)
  Disable cache if explicit memory budget=0 passed (#339)
@NikVolf
Copy link
Contributor

NikVolf commented Feb 13, 2020

Seems it was false alarm from me in substrate.
More careful benchmarking with little variance reveals no difference.

@ordian
Copy link
Member Author

ordian commented Feb 13, 2020

Ok then, closing the PR as it makes no difference in parity-ethereum as well, although the pessimisation issue still holds rust-lang/rust#69024.

@ordian ordian closed this Feb 13, 2020
@ordian ordian deleted the ao-revert-libc-removal branch February 13, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf requested changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A2-insubstantial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ordian @dvdplm @NikVolf @bkchr