Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[parity-crypto] prepare 0.5.0 #336

Merged
merged 7 commits into from
Feb 8, 2020
Merged

[parity-crypto] prepare 0.5.0 #336

merged 7 commits into from
Feb 8, 2020

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Feb 8, 2020

No description provided.

@dvdplm dvdplm self-assigned this Feb 8, 2020
@dvdplm dvdplm requested review from ordian and NikVolf February 8, 2020 17:27
ordian
ordian approved these changes Feb 8, 2020
View reviewed changes
parity-crypto/CHANGELOG.md Outdated Show resolved Hide resolved
@dvdplm @ordian
Update parity-crypto/CHANGELOG.md
1fff66f 
Co-Authored-By: Andronik Ordian <write@reusable.software>
@niklasad1
Copy link
Member

Can we include #337 in this release?

dvdplm added 4 commits February 8, 2020 19:42
@dvdplm
Include #337
1a39a14
@dvdplm
Merge branch 'dp/chore/release-parity-crypto-0.5.0' of github.com:par…
b7496aa 
…itytech/parity-common into dp/chore/release-parity-crypto-0.5.0

* 'dp/chore/release-parity-crypto-0.5.0' of github.com:paritytech/parity-common:
  Update parity-crypto/CHANGELOG.md
@dvdplm
Merge branch 'master' into dp/chore/release-parity-crypto-0.5.0
8acca00 
* master:
  [parity crypto]: remove unused depend `rustc_hex` (#337)
@dvdplm
Sort out rustc-hex
0ea11cc
@dvdplm
Copy link
Contributor Author

dvdplm commented Feb 8, 2020

Can we include #337 in this release?

I jumped the gun on that, apologies. rustc-hex is actually used in parity-crypto when the publickey feature is active.

@ordian
Copy link
Member

ordian commented Feb 8, 2020 •
edited
Loading

Can we include #337 in this release?

I jumped the gun on that, apologies. rustc-hex is actually used in parity-crypto when the publickey feature is active.

Ah, good catch. Indeed

parity-common/parity-crypto/src/publickey/ecdsa_signature.rs

Line 21 in 2c5273c

use rustc_hex::{FromHex, ToHex};

It should be optional then and included in the publickey feature set.

I assumed our tests would have caught that, would be nice to add cargo check -p parity-crypto --all-features in CI to prevent this from happening in the future.

@niklasad1 niklasad1 mentioned this pull request Feb 8, 2020
Closed
@dvdplm dvdplm merged commit fb34955 into master Feb 8, 2020
@dvdplm dvdplm deleted the dp/chore/release-parity-crypto-0.5.0 branch February 8, 2020 20:24
ordian added a commit that referenced this pull request Feb 11, 2020
@ordian
Merge remote-tracking branch 'origin/master' into ao-kvdb-sled
5d5f321 
* origin/master:
  [parity-crypto] prepare 0.5.0 (#336)
  [parity crypto]: remove unused depend `rustc_hex` (#337)
  Update doc comment (#335)
  Add different mode for malloc_size_of_is_0 macro dealing with generics (#334)
ordian added a commit that referenced this pull request Feb 13, 2020
@ordian
Merge branch 'master' into ao-no-overlay
488cb36 
* master:
  prepare rlp-derive release (#344)
  Update/change licenses: MIT/Apache2.0 (#342)
  rlp-derive extracted (#343)
  Format for readme and changelog corrected (#341)
  Parity runtime moved to parity common for publication in crates.io (#271)
  Disable cache if explicit memory budget=0 passed (#339)
  [parity-crypto] prepare 0.5.0 (#336)
  [parity crypto]: remove unused depend `rustc_hex` (#337)
  Update doc comment (#335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikVolf NikVolf NikVolf approved these changes

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees

@dvdplm dvdplm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dvdplm @niklasad1 @ordian @NikVolf