Rename pallet-message-lane into pallet-bridge-messages #834
Conversation
|
What about other pallets though (re: Regarding naming I don't know if adding
would be my preference, but happy to discuss that in a dedicated issue. |
I agree here, we might as well change the logging targets in the other pallets. I think something like
Something like this seems reasonable as well, but yeah this is for a different issue/PR. |
|
It makes sense to me to rename pallet in this PR, because suffix in logs (at least now) depends on the pallet name - it is So if we're ok with |
| storage_keys::message_key::<TestRuntime, DefaultInstance>(&*b"test", 42).0, | ||
| hex!("87f1ffe31b52878f09495ca7482df1a48a395e6242c6813b196ca31ed0547ea79446af0e09063bd4a7874aef8a997cec746573742a00000000000000").to_vec(), | ||
| storage_key, | ||
| hex!("dd16c784ebd3390a9bc0357c7511ed018a395e6242c6813b196ca31ed0547ea79446af0e09063bd4a7874aef8a997cec746573742a00000000000000").to_vec(), |
There was a problem hiding this comment.
Afaik the storage key is computed as twox(pallet-name ++ storage-key-name) => then pallet name has been changed
* use runtime:: prefix for message-lane pallet traces * renamed message-lane (module and primitives) folder into messages * replace "message lane" with "messages" where appropriate
* use runtime:: prefix for message-lane pallet traces * renamed message-lane (module and primitives) folder into messages * replace "message lane" with "messages" where appropriate
(this seems to be common convention after paritytech/substrate#8128)
Another (not super-important) thing is that our pallets have a bit different naming convention. We're going to include
pallet-finality-verifier,pallet-bridge-call-dispatchandpallet-message-laneinto P+K/W+R runtimes. Do we probably need to add thatbridge-thing to all pallets? Or remove it from call dispatch pallet? This seems a bit sloppy now.If we're going to add
bridge-thing to all pallets names, then it worth doing it in this PR for ML pallet.