Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the BridgeRejectObsoleteHeadersAndMessages SignedExtra for BridgeHubRococo/Wococo #1748

Closed
serban300 opened this issue Jan 9, 2023 · 1 comment · Fixed by #1776
Closed

Add the BridgeRejectObsoleteHeadersAndMessages SignedExtra for BridgeHubRococo/Wococo #1748

serban300 opened this issue Jan 9, 2023 · 1 comment · Fixed by #1776
Assignees
@serban300
Milestone
Rococo<>Wococo Pa...

Comments

@serban300
Copy link
Collaborator

We added the bridge_reject_obsolete_headers_and_messages extension to BridgeHubRococo/BridgeHubWococo, but in the relayer we use this which doesn't include it.

We should add the BridgeRejectObsoleteHeadersAndMessages SignedExtra for BridgeHubRococo/Wococo
@serban300 serban300 self-assigned this Jan 9, 2023
@serban300 serban300 mentioned this issue Jan 9, 2023
Merged
@svyatonik
Copy link
Contributor

Just my small comment - since AdditionalSigned is () for the BridgeRejectObsoleteHeadersAndMessages, we don't necessary need to add it to the SignedExtra, but still it'd be good to have it there just for clarity. But we may use some stub instead of it (i.e. struct DummySignedExtra; impl SignedExtension for DummySignedExtra { type AdditionalSigned = (); ... }) to avoid using complex structures there.

This was referenced Jan 13, 2023
Closed
Merged
svyatonik pushed a commit that referenced this issue Jul 17, 2023
@athei
contracts: Reduce session length and enable unstable interfaces (#1748)
00626c0 
* Reduce session for contracts to 10 minutes

* Build pallet-contracts with unstable interface

* Set `MinCandidates` to 0 to allow only invulnerables as collators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@serban300 serban300

Labels
None yet
Projects
None yet
Milestone
Rococo<>Wococo Parachain Bridge Release
Development

Successfully merging a pull request may close this issue.

Define a separate signed extension for BHR/BHW serban300/parity-bridges-common
2 participants
@svyatonik @serban300