Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI optimizations #84

Merged
merged 11 commits into from
Sep 16, 2021
Merged

CI optimizations #84

merged 11 commits into from
Sep 16, 2021

Conversation

TriplEight
Copy link
Contributor

  • optimize caching (swatinem's action covers more rust cache)
  • cancel previous CI runs on the new commits
  • pin actions' versions
  • add dependabot to update cargo deps and github actions versions

Also, I'd like to use simple run: instead of harder-readable special actions, but it's cosmetic
I'm not quite sure if sccache is actually helpful here, maybe it's worth a shot next time.

@TriplEight TriplEight requested a review from sorpaas September 15, 2021 08:48
@TriplEight TriplEight self-assigned this Sep 15, 2021
@sorpaas
Copy link
Member

sorpaas commented Sep 15, 2021

Are you sure this works? It's cancelling its own runs.

@TriplEight
Copy link
Contributor Author

@sorpaas fixed

@sorpaas
Copy link
Member

sorpaas commented Sep 16, 2021

There still seems to be something wrong. Any windows builds always stuck at the last step.

@sorpaas
Copy link
Member

sorpaas commented Sep 16, 2021

Maybe just remove the rust-cache step? What does it do anyway?

@TriplEight
Copy link
Contributor Author

@athei it's already there

@TriplEight
Copy link
Contributor Author

removing the modern cache handling due to Swatinem/rust-cache#31

@sorpaas sorpaas merged commit 22b99ba into master Sep 16, 2021
@athei athei deleted the 3x8_opt_caching branch September 16, 2021 18:17
trevor-crypto pushed a commit to monacohq/libsecp256k1 that referenced this pull request May 31, 2022
* CI: optimize caching

* CI: cancel previous run on a new commit

* CI: fix actions versions

* CI: add dependabot to update cargo deps and github actions versions

* CI: fix cancel action version

* CI: fix cancel action version again

* CI: fix cancel action version again again

* CI: add cancel-workflow-action everywhere

* CI: update actions versions

* CI: separate windows jobs

* CI: separate windows jobs 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants