fix(client): support batched notifications #1327
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the examples in the jsonrpc specification, it is valid to include only notifications in a batch.
rpc call Batch (all notifications):
This change adds support for handling this use case.
I ran into this while trying to leverage this library for a proof of conept I was working on a little while back,. My particular use case was using the client crate of this library to communicate with an existing service. I realized I never upstreamed this change and figured it might be useful to others.
I didn't see any contribution guidelines for this project, so please let me know if I'm missing any information. If you're not accepting external contributions I understand and can close this out. Thanks for your time.