refactor(client): unify ws ping/pong API with the server #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasad1
commented
Dec 7, 2023
niklasad1
commented
Dec 7, 2023
2c14268 to
5aa1ff8
Compare
niklasad1
commented
Dec 7, 2023
niklasad1
commented
Dec 7, 2023
niklasad1
commented
Dec 7, 2023
Merged
jsdw
reviewed
Dec 8, 2023
| if let Err(err) = sender.send_ping().await { | ||
| tracing::error!(target: LOG_TARGET, "Could not send ping frame: {err}"); | ||
| break Err(Error::Custom("Could not send ping frame".into())); | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Nice to de-duplicate these bits :)
jsdw
approved these changes
Dec 8, 2023
niklasad1
commented
Dec 8, 2023
lexnv
reviewed
Dec 8, 2023
| /// | ||
| /// Such that the `inactive_limit` should be configured to longer than a single | ||
| /// WebSocket ping takes or it might be missed and may end up | ||
| /// terminating the connection. |
There was a problem hiding this comment.
nit: Might be worth stating the default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the clients to support a similar WebSocket ping/pong as the server which
was introduced in #1248
The
PingConfigtype is duplicated in the server and client but I'm fine with that for now.After introducing
Instantin code I realized that the ping/pong interval would panic in wasm and I have removed ping/pongs completely because gloo-net doesn't support that anyway.The other solution is to use some other crates where instants/interval stream are supported but it's not worth the effort IMHO and I think there was some reason in JS land where it's not possible to have client-side initiated pings.