fix(host filtering): allow hosts with multiple ports #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring moved to another library where an `Authority` with the "same host name" but a different port was overwritten and this commit fixes that several ports with the same host name can be configured and work properly.
niklasad1
commented
Oct 31, 2023
niklasad1
commented
Oct 31, 2023
server/src/middleware/host_filter.rs
Outdated
|
|
||
| match (p, &other.port) { | ||
| ports.iter().any(|p| match (p, &other.port) { |
There was a problem hiding this comment.
I expect this list to be small and linear search should ok here, we could change this to a HashSet or BTreeSet though
lexnv
approved these changes
Nov 14, 2023
jsdw
approved these changes
Dec 5, 2023
…ng-multiple-ports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring moved to another library where an
Authoritywith the "same host name" but a different port was overwritten and this commit fixes that several ports with the same host name can be configured and work properly.