Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: downgrade log for unknown subscription to DEBUG #1185

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

xlc
Copy link
Contributor

@xlc xlc commented Aug 14, 2023

Why this is a warning? It is not possible to completely eliminate such case and there is not really anything to be worried about when this happens.

@xlc xlc requested a review from a team as a code owner August 14, 2023 23:51
@xlc xlc changed the title reduce logging level reduce logging level for Subscription is not active message Aug 14, 2023
@niklasad1
Copy link
Member

niklasad1 commented Aug 15, 2023

Fair enough, it can occur if the client terminates the subscription and until the unsubscription call has been received additional notifications/subscription messages can be sent out but if this occurs frequently I'm a little worried that is some issue somewhere that's why it was a warn (could be a client bug, unsubscribe call isn't sent or misbehaving server)

Fine, it's annoying debug is better

@niklasad1 niklasad1 changed the title reduce logging level for Subscription is not active message client: downgrade log for unknown subscription to DEBUG Aug 15, 2023
@niklasad1 niklasad1 merged commit 7d924ff into paritytech:master Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants