make Server::start infallible and add fn builder()
#1137
Conversation
|
Yeah, I'm quite tempted of removing the entire start API then just start the server from the Builder but it may useful to manage when the server is started, not sure. |
|
Having a guide gander, it looks like you may as well keep a separate thing to start it offhand; I tend to feel that breaking functionality apart like this is a good thing (and then providing higher level stuff to do the common cases where applicable) (I'd probably add a |
Server::start infallibleServer::start infallible and add fn builder()
|
I will remove the It's quite messy to migrate all tests. |
Server::start infallible and add fn builder()Server::start infallible and add fn builder()
paritytech/jsonrpsee#1137 This change allows to compile with jsonrpsee v0.19.0
* Update jsonrpsee to 0.18.0 * Update jsonrpsee ErrorObject After v0.18.0, jsonrpsee::core::Error was removed. These are just naive changes to get it to compile. See: https://github.com/paritytech/jsonrpsee/releases/tag/v0.18.0 * Update jsonrpsee to 0.19.0 * jsonrpsee Server::start is infallible according to: paritytech/jsonrpsee#1137 This change allows to compile with jsonrpsee v0.19.0 * Release the linux riscv64gc version Depends on #372. Part of #370. * Install risc-v version with heliosup. * cargo fmt
Server::startwas infallible to let's change the API to reflect that.