This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
Example Parachain Integration tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weezy20
reviewed
Sep 27, 2023
weezy20
reviewed
Oct 2, 2023
weezy20
reviewed
Oct 2, 2023
weezy20
reviewed
Oct 4, 2023
| hrmp_channels: | ||
| proposed_max_capacity: &max_capacity 8 | ||
| proposed_max_message_size: &max_message_size 1048576 | ||
| channel: &channel { |
There was a problem hiding this comment.
I don't think we are using this (&channel) variable binding anywhere. Okay to omit it?
|
Looks good to me. |
weezy20
approved these changes
Oct 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved the issue [QA] Example Parachain Integration tests #77.
Added the instructions of how to run the integration tests, set up the zombienet file and two tests files:
force_hrmp_open_channels: creates an HRMP channel with asset-hub and checks that everything is created propertly.I decided to create this test, because there currently there is an issue: (draft) Zombienet test with preopen hrmp with zombienet investigation paritytech/polkadot-sdk#1616 that is unable to create the hrmp channels directly with zombienet, so this test can be useful.
transact: Test to make a transfer from this parachain sovereign account to asset-hub local network sovereign account via a XCM Transact in the Relay Chain.Bonus point:
We can create one reserve transfer similar to the one in Trappist once we have this: Minimal AssetHub integration #79