Companion for Polkadot#7337

[mrcnski]

Companion for paritytech/polkadot#7337
Companion for paritytech/polkadot#7566

[mrcnski]

I think we may need to rig this crate to build the workers for this to work. Can someone please explain what this crate does exactly, does it call PVF preparation/execution?

[ordian]

I don't think Cumulus spawns PVF workers. There's some discussion here: paritytech/polkadot#6497

[mrcnski]

For a collator the runtime is trusted, for a validator the runtime is not.

Okay yeah, that makes perfect sense. So we don't need most of what I added here, will remove.

[command-bot]

@paritytech-cicd-pr Requester could not be detected as a member of an allowed organization.

[dmitry-markin]

I'd rather somebody from the main PR reviewers with understanding of underlying changes reviewed and approved this instead of me. @koute could you have a look?

[paritytech-processbot]

Waiting for commit status.

[paritytech-processbot]

Merge cancelled due to error. Error: Statuses failed for cf97d9f

[mrcnski]

polkadot-parachain tests are failing now with the polkadot PR merged. The polkadot-parachain node expects worker binaries even though those should be ignored for collators. So I guess this node does not run in collator mode? I think it's supposed to, can I update it or is there a reason it doesn't?

[2023-07-31 13:58:57] 2023-07-31 13:58:51 Is collating: no    

Advice would be appreciated, cumulus CI for other PRs will be broken until this is fixed.

[skunert]

https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3298541

We instantiate the polkadot node here:

cumulus/client/relay-chain-inprocess-interface/src/lib.rs

Lines 273 to 293 in 2df9b9a

	let (is_collator, maybe_collator_key) = if parachain_config.role.is_authority() {
	let collator_key = CollatorPair::generate().0;
	(polkadot_service::IsCollator::Yes(collator_key.clone()), Some(collator_key))
	} else {
	(polkadot_service::IsCollator::No, None)
	};
	let relay_chain_full_node = polkadot_service::build_full(
	config,
	is_collator,
	None,
	// Disable BEEFY. It should not be required by the internal relay chain node.
	false,
	None,
	telemetry_worker_handle,
	true,
	polkadot_service::RealOverseerGen,
	None,
	None,
	hwbench,
	)?;

It is only started as collator, if the node is run as a collator. If it is just a parachain full node, we pass polkadot_service::IsCollator::No.

[skunert]

While thinking about it, why does a polkadot full-node require the workers, even if we pass polkadot_service::IsCollator::No? We never spawn a validator here

[mrcnski]

Agreed @skunert. Perhaps we should add a separate parameter is_validator and require the workers based on that instead.

[skunert]

Agreed @skunert. Perhaps we should add a separate parameter is_validator and require the workers based on that instead.

Hmm maybe I am missing something, but that should not be necessary. Via config.role.is_authority() and the collator parameter you should be able to figure out if the node is a validator right? Similar to these checks?
https://github.com/paritytech/polkadot/blob/5303d8c2099451ad05fe7a303d8b367a0a9be0c3/node/service/src/lib.rs#L771-L772
Edit: I see that is what you did in the fix PR 👍

[paritytech-processbot]

Waiting for commit status.