Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

doc fix #2676

Merged
merged 1 commit into from
Jun 1, 2023
Merged

doc fix #2676

merged 1 commit into from
Jun 1, 2023

Conversation

michalkucharczyk
Copy link
Contributor

fixing error:

warning: unresolved link to `well_known_keys::CODE`
   --> pallets/parachain-system/src/lib.rs:560:12
    |
560 |     #[pallet::storage]
    |               ^^^^^^^
    |
    = note: the link appears in this line:
            " As soon as the relay chain gives us the go-ahead signal, we will overwrite the [`:code`][well_known_keys::CODE]"
                                                                                                       ^^^^^^^^^^^^^^^^^^^^^
    = note: no item named `well_known_keys` in scope
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default

@michalkucharczyk
doc fix
8e417f0 
fixing error:
```
warning: unresolved link to `well_known_keys::CODE`
   --> pallets/parachain-system/src/lib.rs:560:12
    |
560 |     #[pallet::storage]
    |               ^^^^^^^
    |
    = note: the link appears in this line:
            " As soon as the relay chain gives us the go-ahead signal, we will overwrite the [`:code`][well_known_keys::CODE]"
                                                                                                       ^^^^^^^^^^^^^^^^^^^^^
    = note: no item named `well_known_keys` in scope
    = note: `#[warn(rustdoc::broken_intra_doc_links)]` on by default
```
@michalkucharczyk michalkucharczyk added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 1, 2023
@michalkucharczyk
Copy link
Contributor Author

Failure is happening on master CI:
https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/2930737

@michalkucharczyk michalkucharczyk requested review from niklasad1, lexnv and a team June 1, 2023 19:59
@bkchr bkchr merged commit 3d7604e into master Jun 1, 2023
@bkchr bkchr deleted the mku-well-known-keys-doc-fix branch June 1, 2023 23:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@altonen altonen altonen approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

@niklasad1 niklasad1 Awaiting requested review from niklasad1

@lexnv lexnv Awaiting requested review from lexnv

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalkucharczyk @bkchr @ggwpez @altonen