Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update Cumulus to common Cargo formmating scheme #1050

Merged
merged 9 commits into from
Mar 2, 2022

Conversation

nuke-web3
Copy link
Contributor

This is a proposed standardized scheme for all of Cumulus Cargo.toml files. The PR's commits are piecewise, to review in parts for convenience, as there are many files touched.

No code changes are made in this PR, only ordering and comments as needed

Motivation

The Cargo.toml files are presently somewhat unsorted and non-uniform. It sometimes is non-obvious what aspects are where to be found when moving though Cumulus, occasionally leading confusion or missing key common/missing aspects between different crates.

Implementation

This scheme cleans all files to fit the same standard format where all deps are alphabetical, in order by relevant repository being used to obtain the crate:

[package]
...

[dependencies]
{**crates.io hosted**} 

# Substrate
.... = { git = "https://github.com/paritytech/substrate", branch = "master" }

# Polkadot
... = { git = "https://github.com/paritytech/polkadot", branch = "master" }

# Cumulus
... = { path = "..." }

[dev-dependencies]
{**same sections as above if needed**}

[build-dependencies]
substrate-wasm-builder = { git = "https://github.com/paritytech/substrate", branch = "master" }

[features]
default = [ "std" ]
std = [
	{**same order as [dependencies] section above**}
]

@nuke-web3 nuke-web3 added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low 📌 labels Feb 26, 2022
@nuke-web3 nuke-web3 force-pushed the ds/clean-cargo-files branch from 5c2d5da to a727e1b Compare March 2, 2022 01:26
@nuke-web3 nuke-web3 requested a review from bkchr March 2, 2022 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants