This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Pass CLI arguments to parachain/relay chain node #34
Assignees
Comments
This was referenced Jan 16, 2020
This feature couldn't be implemented without the refactoring in paritytech/substrate#4692 I close this ticket and #24 will remain to fix the defaults for the ports. |
cecton
added a commit
to paritytech/substrate
that referenced
this issue
Jan 30, 2020
It changes the way we extended the CLI functionalities of substrate to allow more flexibility. (If this was not clear, here is another version: it changes the `sc_cli` API to allow more flexibility).
This touches a few important things:
- the startup of the async task with tokei:
This was in node and node-template and I moved it to substrate. The idea is to have 1 time the code that handles unix signals (SIGTERM and SIGINT) properly. It is however possible to make this more generic to wait for a future instead and provide only a helper for the basic handling of SIGTERM and SIGINT.
- increased the version of structopt and tokei
- no more use of structopt internal's API
- less use of generics
Related to #4643 and paritytech/cumulus#42: the implementation of "into_configuration" and "get_config" are similar but with better flexibility so it is now possible in cumulus to have the command-line arguments only of the run command for polkadot if we want
Related to paritytech/cumulus#24 and paritytech/cumulus#34 : it will now be possible to make a configuration struct for polkadot with some overrides of the default parameters much more easily.
Maharacha
pushed a commit
to Maharacha/cumulus
that referenced
this issue
May 10, 2023
* [launch-runtime] add sudo only filter * [launch-runtime] fix negated dispatchable filter * [GA] cancel previous runs and add cargo cache * [launch-runtime] fix filter Co-authored-by: brenzi <brenzi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When running the collator, I want to pass CLI arguments that are related to the parachain and to the relay chain. As both are substrate projects, we need to make it possible to pass the same arguments twice to the same binary.
We want the following syntax:
collator --name parachain -- --name relaychainThe first arguments before the
--are the parachain parameters and everything after--is a relay chain parameter.--helpshould make it clear how we expect parameters to be passed.Maybe we could also include some reasonable defaults for ports, so that they don't clash: #24
Like putting the relay chain ports at
default + 1(if they are not overwritten by a cli arg)The text was updated successfully, but these errors were encountered: