Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: misc. smoldot cleanup #876

Merged
merged 9 commits into from
Apr 12, 2023
Merged

fix: misc. smoldot cleanup #876

merged 9 commits into from
Apr 12, 2023

Conversation

harrysolovay
Copy link
Contributor

@harrysolovay harrysolovay commented Apr 11, 2023 •
edited
Loading

Fixes #865
Closes #871

  • enable one to override a codegened ChainRune with a smoldot connection using the with method
  • reference counting chain count for graceful smoldot exit
  • use hex.encodePrefixed instead of hex.encode (otherwise, smoldot storage retrievals throw)

@deno-deploy deno-deploy bot requested a deployment to Preview April 12, 2023 01:46 Abandoned
@deno-deploy deno-deploy bot requested a deployment to Preview April 12, 2023 14:19 Abandoned
@harrysolovay harrysolovay changed the title feat: allow overriding connection fix: misc. smoldot cleanup Apr 12, 2023
tjjfvi
tjjfvi reviewed Apr 12, 2023
View reviewed changes
rpc/smoldot.ts Outdated Show resolved Hide resolved
fluent/ChainRune.ts Outdated Show resolved Hide resolved
@harrysolovay @tjjfvi
Update fluent/ChainRune.ts
210eb53 
Co-authored-by: T6 <t6@t6.fyi>
@deno-deploy deno-deploy bot requested a deployment to Preview April 12, 2023 14:45 Abandoned
kratico
kratico previously approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@kratico kratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@harrysolovay harrysolovay requested a review from tjjfvi April 12, 2023 15:27
@harrysolovay harrysolovay marked this pull request as ready for review April 12, 2023 15:27
@harrysolovay harrysolovay added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit 85dee60 Apr 12, 2023
@harrysolovay harrysolovay deleted the with-connection branch April 12, 2023 17:04
@kratico kratico mentioned this pull request Apr 12, 2023
Closed
kratico added a commit that referenced this pull request Apr 12, 2023
@kratico
Revert "fix: misc. smoldot cleanup (#876)"
29cea24 
This reverts commit 85dee60.
kratico added a commit that referenced this pull request Apr 13, 2023
@kratico
Revert "fix: misc. smoldot cleanup (#876)"
8038f00 
This reverts commit 85dee60.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kratico kratico kratico approved these changes

@tjjfvi tjjfvi tjjfvi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

smoldot RPC connection exit issue
3 participants
@harrysolovay @kratico @tjjfvi