Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: cors server errors #834

Merged
merged 2 commits into from
Apr 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/capi.dev/delegator.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { serve } from "../../deps/std/http.ts"
import { TimedMemo } from "../../util/memo.ts"
import { f, handleErrors } from "../mod.ts"
import { f, handleCors, handleErrors } from "../mod.ts"

serve(handleErrors(handler))
serve(handleCors(handleErrors(handler)))

const ttl = 60_000
const shaAbbrevLength = 8
Expand Down
46 changes: 40 additions & 6 deletions server/handler.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { Handler } from "../deps/std/http.ts"
import { Handler, Status } from "../deps/std/http.ts"
import { Env } from "./Env.ts"
import * as f from "./factories.ts"
import { parsePathInfo } from "./PathInfo.ts"

export function handler(env: Env): Handler {
return handleErrors(async (request) => {
return handleCors(handleErrors(async (request) => {
const url = new URL(request.url)
const { pathname } = url
if (pathname === "/") return new Response("capi dev server active")
Expand Down Expand Up @@ -34,19 +34,53 @@ export function handler(env: Env): Handler {
} catch (_e) {}
}
return f.notFound()
})
}))
}

const staticDirs = ["../", "./static/"].map((p) => import.meta.resolve(p))

export function handleErrors(handler: (request: Request) => Promise<Response>) {
return async (request: Request) => {
export function handleErrors(handler: Handler): Handler {
return async (request, connInfo) => {
try {
return await handler(request)
return await handler(request, connInfo)
} catch (e) {
if (e instanceof Response) return e.clone()
console.error(e)
return f.serverError(Deno.inspect(e))
}
}
}

export function handleCors(handler: Handler): Handler {
return async (request, connInfo) => {
const newHeaders = new Headers()
newHeaders.set("Access-Control-Allow-Origin", "*")
newHeaders.set("Access-Control-Allow-Headers", "*")
newHeaders.set("Access-Control-Allow-Methods", "*")
newHeaders.set("Access-Control-Allow-Credentials", "true")

if (request.method === "OPTIONS") {
return new Response(null, {
headers: newHeaders,
status: Status.NoContent,
})
}

const res = await handler(request, connInfo)

// Deno.upgradeWebSocket response objects cannot be modified
if (res.headers.get("upgrade") !== "websocket") {
for (const [k, v] of res.headers) {
newHeaders.append(k, v)
}

return new Response(res.body, {
headers: newHeaders,
status: res.status,
statusText: res.statusText,
})
}

return res
}
}