Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

fix: broken patterns + examples #786

Merged
merged 21 commits into from
Mar 24, 2023
Merged

fix: broken patterns + examples #786

merged 21 commits into from
Mar 24, 2023

Conversation

harrysolovay
Copy link
Contributor

@harrysolovay harrysolovay commented Mar 23, 2023

Fixes #761

Fixes...

  • broken patterns, including multisigs, virtual multisigs and size tree
  • broken examples
  • ws rpc close error

@harrysolovay harrysolovay changed the title fix: broken examples fix: broken patterns + examples Mar 23, 2023
@ryanleecode
Copy link
Contributor

polkadot_js_signer is still failing but wasn't modified in this PR. Not sure if its within scope.

error: Uncaught (in promise) Unhandled {
  value: ServerError: Invalid Transaction
    at RunMap.fn (file:///home/ryan/Documents/Repositories/capi/fluent/ConnectionRune.ts:53:32)
    at RunMap._evaluate (file:///home/ryan/Documents/Repositories/capi/rune/ValueRune.ts:150:40)
    at async RunMap.evaluate (file:///home/ryan/Documents/Repositories/capi/rune/Rune.ts:222:14)
    at async RunThrows._evaluate (file:///home/ryan/Documents/Repositories/capi/rune/ValueRune.ts:181:14)
    at async RunThrows.evaluate (file:///home/ryan/Documents/Repositories/capi/rune/Rune.ts:222:14)
    at async Promise.all (index 0)
    at async RunLs.evaluate (file:///home/ryan/Documents/Repositories/capi/rune/Rune.ts:222:14)
    at async RunMap._evaluate (file:///home/ryan/Documents/Repositories/capi/rune/ValueRune.ts:148:20)
    at async RunMap.evaluate (file:///home/ryan/Documents/Repositories/capi/rune/Rune.ts:222:14)
    at async RunFilter._evaluate (file:///home/ryan/Documents/Repositories/capi/rune/ValueRune.ts:261:21)
Caused by Invalid Transaction
}

finished polkadot_js_signer.ts

@harrysolovay
Copy link
Contributor Author

I opened #791 specifically to track the PJS compat pattern, which will be addressed in a subsequent PR.

@ryanleecode
Copy link
Contributor

sounds good

tjjfvi
tjjfvi previously approved these changes Mar 24, 2023
@harrysolovay harrysolovay enabled auto-merge March 24, 2023 15:59
patterns/multisig/VirtualMultisigRune.ts Show resolved Hide resolved
patterns/sizeTree.ts Outdated Show resolved Hide resolved
rpc/ws.ts Outdated Show resolved Hide resolved
@harrysolovay harrysolovay disabled auto-merge March 24, 2023 16:13
tjjfvi
tjjfvi previously approved these changes Mar 24, 2023
ryanleecode
ryanleecode previously approved these changes Mar 24, 2023
@tjjfvi tjjfvi mentioned this pull request Mar 24, 2023
@harrysolovay harrysolovay added this pull request to the merge queue Mar 24, 2023
Merged via the queue into main with commit 508abee Mar 24, 2023
@harrysolovay harrysolovay deleted the example-cleanup branch March 24, 2023 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

triage failing examples
3 participants