Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

feat: use capi-binary-builds to auto-install deps #777

Merged
merged 11 commits into from
Mar 27, 2023
Merged

feat: use capi-binary-builds to auto-install deps #777

merged 11 commits into from
Mar 27, 2023

Conversation

tjjfvi
Copy link
Contributor

@tjjfvi tjjfvi commented Mar 22, 2023

Resolves #651

@tjjfvi tjjfvi marked this pull request as ready for review March 22, 2023 14:39
@tjjfvi tjjfvi requested a review from harrysolovay as a code owner March 22, 2023 14:39
@tjjfvi
Copy link
Contributor Author

tjjfvi commented Mar 22, 2023

Looks like this brought star down from ~7m to ~2m... not sure why, but I'll take it

@tjjfvi
Copy link
Contributor Author

tjjfvi commented Mar 22, 2023

Ah, probably because it can now always hit the cache for the metadata

harrysolovay
harrysolovay previously approved these changes Mar 22, 2023
View reviewed changes
@tjjfvi tjjfvi added this pull request to the merge queue Mar 22, 2023
@tjjfvi tjjfvi removed this pull request from the merge queue due to a manual request Mar 22, 2023
harrysolovay
harrysolovay previously approved these changes Mar 22, 2023
View reviewed changes
@tjjfvi tjjfvi enabled auto-merge March 22, 2023 16:49
@harrysolovay harrysolovay mentioned this pull request Mar 22, 2023
Merged
@tjjfvi tjjfvi force-pushed the auto-install branch 2 times, most recently from b4b6840 to 03d0385 Compare March 27, 2023 13:51
@deno-deploy deno-deploy bot requested a deployment to Preview March 27, 2023 13:52 Abandoned
@tjjfvi tjjfvi force-pushed the auto-install branch 2 times, most recently from f6559eb to 3b9e442 Compare March 27, 2023 13:59
@tjjfvi tjjfvi mentioned this pull request Mar 27, 2023
Closed
@tjjfvi
Copy link
Contributor Author

tjjfvi commented Mar 27, 2023 •
edited
Loading

Star still isn't exiting cleanly, but at least it's exiting at all now. #805

@tjjfvi tjjfvi requested a review from harrysolovay March 27, 2023 14:40
@tjjfvi tjjfvi added this pull request to the merge queue Mar 27, 2023
Merged via the queue into main with commit 492a35a Mar 27, 2023
@tjjfvi tjjfvi deleted the auto-install branch March 27, 2023 15:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanleecode ryanleecode ryanleecode left review comments

@harrysolovay harrysolovay harrysolovay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

auto-installation prompt/flow for provider dependencies
4 participants
@tjjfvi @ryanleecode @harrysolovay @kratico