chore: make use of users util in examples #752

harrysolovay · 2023-03-15T18:08:55Z

Thanks to #725

kratico

🎉 LGTM

tjjfvi

Given that alice/bob/charlie/dave/eve have specific meaning in the polkadot context, perhaps for these test users we should adopt a different set of names. Maybe

alexa, billy, carol, david, emily

... or just a, b, c, d, e, but that seems less fun.

make use of users util

521fdac

harrysolovay requested a review from tjjfvi as a code owner March 15, 2023 18:08

harrysolovay requested a review from kratico March 15, 2023 18:09

kratico previously approved these changes Mar 15, 2023

View reviewed changes

tjjfvi reviewed Mar 15, 2023

View reviewed changes

encorporate feedback

c1429c2

harrysolovay dismissed kratico’s stale review via c1429c2 March 16, 2023 02:17

harrysolovay added 2 commits March 16, 2023 03:55

minor fmt change

4dc9403

renames

1890d67

tjjfvi approved these changes Mar 16, 2023

View reviewed changes

harrysolovay enabled auto-merge March 16, 2023 14:48

harrysolovay added this pull request to the merge queue Mar 16, 2023

Merged via the queue into main with commit 6ff306e Mar 16, 2023

harrysolovay deleted the bye-bye-alice branch March 16, 2023 15:00

tjjfvi mentioned this pull request Mar 27, 2023

fix: pjs signer example #803

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: make use of users util in examples #752

chore: make use of users util in examples #752

harrysolovay commented Mar 15, 2023

kratico left a comment

tjjfvi left a comment

chore: make use of users util in examples #752

chore: make use of users util in examples #752

Conversation

harrysolovay commented Mar 15, 2023

kratico left a comment

Choose a reason for hiding this comment

tjjfvi left a comment

Choose a reason for hiding this comment