This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanleecode
reviewed
Feb 27, 2023
return Rune.resolve(events).map((events) => | ||
events | ||
.map((e) => e.event) | ||
.filter((event): event is RuntimeEvent.Proxy => event.type === "Proxy") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont we have codegen guard for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid using codegened runtime code in patterns, as it makes them unusable to consuming NodeJS projects (for now).
tjjfvi
reviewed
Feb 27, 2023
This was referenced Feb 27, 2023
Closed
harrysolovay
force-pushed
the
multisig-proxy-patterns
branch
from
February 27, 2023 15:59
04b5b9a
to
2d3fc4e
Compare
ryanleecode
reviewed
Feb 27, 2023
} | ||
|
||
ratify<X>(...[senderIndex, call]: RunicArgs<X, [number, Chain.Call<C>]>) { | ||
const call_ = this.chain.extrinsic(Rune.rec({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proxy call needs to happen outside of ratify. We can't assume every ratify call will interact with the stash
harrysolovay
force-pushed
the
multisig-proxy-patterns
branch
from
February 28, 2023 16:09
b322af3
to
d9fe4ce
Compare
Co-authored-by: T6 <t6@t6.fyi>
ryanleecode
force-pushed
the
multisig-proxy-patterns
branch
from
February 28, 2023 22:12
0126374
to
ba69b0e
Compare
ryanleecode
approved these changes
Mar 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #658
Closes #555
This PR takes the learnings from #555 and integrates them into a
VirtualMultisigRune
. One can deploy aVirtualMultisigRune
like so:To hydrate from the state hex, we do the following.
To ratify a call from the stash account (signatory -> signatory proxy -> multisig -> stash), we can use virtual multisig's ratify method.
Open questions:
VirtualMultisig
depend on mappings from the member accounts to the proxy accounts? This would allow us to avoid the DX of passing signatory index into theratify
method.