Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HMR hostname in browser #965

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

jkrehm
Copy link
Contributor

@jkrehm jkrehm commented Mar 8, 2018

Fixes regression introduced in #921

Fixes regression introduced in parcel-bundler#921
@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #965 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #965      +/-   ##
==========================================
+ Coverage   89.75%   89.98%   +0.23%     
==========================================
  Files          68       68              
  Lines        3437     2717     -720     
==========================================
- Hits         3085     2445     -640     
+ Misses        352      272      -80
Impacted Files Coverage Δ
src/Bundler.js 92.85% <ø> (ø) ⬆️
src/utils/objectHash.js 42.3% <0%> (-42.31%) ⬇️
src/assets/GlobAsset.js 58.66% <0%> (-40%) ⬇️
src/utils/config.js 59.42% <0%> (-28.99%) ⬇️
src/assets/RawAsset.js 71.42% <0%> (-21.43%) ⬇️
src/utils/md5.js 83.33% <0%> (-16.67%) ⬇️
src/utils/urlJoin.js 84.61% <0%> (-15.39%) ⬇️
src/utils/fs.js 88.23% <0%> (-11.77%) ⬇️
src/utils/is-url.js 88.88% <0%> (-11.12%) ⬇️
src/utils/promisify.js 77.77% <0%> (-11.12%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ceb7aa...51eb455. Read the comment docs.

@devongovett devongovett merged commit 0dc062f into parcel-bundler:master Mar 9, 2018
@jkrehm
Copy link
Contributor Author

jkrehm commented Mar 9, 2018

Thanks!

@jkrehm jkrehm deleted the fix-hmr-hostname branch March 9, 2018 05:44
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes regression introduced in #921
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Fixes regression introduced in #921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants