Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uglify Sourcemap improvements #875

Merged
merged 3 commits into from
Feb 21, 2018
Merged

Uglify Sourcemap improvements #875

merged 3 commits into from
Feb 21, 2018

Conversation

devongovett
Copy link
Member

Just a couple improvements. Please test them out and merge if you like it @DeMoorJasper! 😄

  1. Fixed a couple bugs I found in testing with the mapping search going out of bounds.
  2. Made the uglify sourcemaps slightly faster by using the raw mappings rather than generating and parsing the sourcemap. This is done using the output.source_map option which is normally uglify's internal sourcemap generator but we emulate the add function to point to our sourcemap instead.

@devongovett
Faster uglify sourcemaps
8e8a60e 
Use raw mappings rather than generating and parsing the sourcemap from uglify.
@devongovett devongovett force-pushed the sourcemap-improvements branch from 9ba65d2 to 8e8a60e Compare February 21, 2018 07:58
DeMoorJasper
DeMoorJasper approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Looks like u found a way to not use the stringified result :)

@DeMoorJasper DeMoorJasper merged commit 59436cd into feature/uglify-sourcemaps Feb 21, 2018
@DeMoorJasper DeMoorJasper deleted the sourcemap-improvements branch February 21, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devongovett @DeMoorJasper