Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JSX support for "Nerv" #821

Merged
merged 1 commit into from
Feb 16, 2018
Merged

add JSX support for "Nerv" #821

merged 1 commit into from
Feb 16, 2018

Conversation

g-plane
Copy link
Contributor

@g-plane g-plane commented Feb 16, 2018

@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #821 into master will decrease coverage by 4.27%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #821      +/-   ##
==========================================
- Coverage   93.41%   89.14%   -4.28%     
==========================================
  Files          68       68              
  Lines        3753     2800     -953     
==========================================
- Hits         3506     2496    -1010     
- Misses        247      304      +57
Impacted Files Coverage Δ
src/transforms/babel.js 96.17% <100%> (-2.47%) ⬇️
src/HMRServer.js 52.63% <0%> (-37.85%) ⬇️
src/Asset.js 66.94% <0%> (-31.36%) ⬇️
src/utils/installPackage.js 77.41% <0%> (-19.46%) ⬇️
src/utils/config.js 76.92% <0%> (-17.45%) ⬇️
src/Logger.js 81.9% <0%> (-12.39%) ⬇️
src/Bundle.js 89.79% <0%> (-9.21%) ⬇️
src/assets/GlobAsset.js 90% <0%> (-8.75%) ⬇️
src/visitors/matches-pattern.js 92% <0%> (-8%) ⬇️
src/Server.js 84.37% <0%> (-7.3%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852f6b3...8e2973c. Read the comment docs.

Copy link
Contributor

@brandon93s brandon93s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration files have been added, but I don't see any test(s) using them.

@g-plane
Copy link
Contributor Author

g-plane commented Feb 16, 2018

Sorry for missing it. I will add it later.

@devongovett devongovett merged commit 1e12975 into parcel-bundler:master Feb 16, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants