fix(image transformer): Update supported formats #8028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes parcel-bundler#8021 These formats are shown as supported here: https://github.com/parcel-bundler/parcel/blob/e0440dcbe6d6e419a412c8c568d94715cdb4282a/packages/transformers/image/src/ImageTransformer.js#L9 In the docs they are also stated as supported, but are not registered in the default config: https://github.com/parcel-bundler/website/blob/v2/src/recipes/image.md?plain=1#L34
mischnic
approved these changes
May 2, 2022
|
I see this was merged almost 3 weeks ago, when will it be released and/or how can I bring it into my project? I'm trying to use a |
|
Release will be soon, but in the meantime you can always add a {
"extends": "@parcel/config-default",
"transformers": {
"*.gif": ["@parcel/transformer-image"]
}
}Check out the docs if you want to learn more about configuring parcel. https://parceljs.org/features/plugins/ |
|
Thank you! |
gorakong
pushed a commit
that referenced
this pull request
Nov 3, 2022
* upstream/v2: fix: getNodeIdsConnected should remove duplicate values (#8054) chore: should log unsupported type not zero and toLocaleString's option typo (#8002) Allow animated images (#8018) Add "key" and "update_url" to webextension manifest schema (#8043) Allow to define the "compilerOptions" of the VueTransformer (#8031) fix(image transformer): Update supported formats (#8028) support for `oauth2` field in mv3 (#8037) Update @parcel/css to 1.8.2 (#8044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue: #8021
↪️ Pull Request
These formats are shown as supported here:
parcel/packages/transformers/image/src/ImageTransformer.js
Line 9 in e0440dc
In the docs they are also stated as supported, but are not registered in the default config: https://github.com/parcel-bundler/website/blob/v2/src/recipes/image.md?plain=1#L34
💻 Examples
These formats are silently not transformed (see original issue)
🚨 Test instructions
Similarly to #8018 I'm not sure if this needs tests, but if it does, please let me know and I can convert this to a draft. The image transformer doesn't seem to have tests currently.
✔️ PR Todo