Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'id' to the module variable #688

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Conversation

theKashey
Copy link
Contributor

Just letting module.id to exists.

Partially fixes #619.
Making parcel compatible with React-hot-loader v4 (gaearon/react-hot-loader#818)

@theKashey
Copy link
Contributor Author

🙇tests are green on localhost 🤷‍♂️

@davidnagli
Copy link
Contributor

The CI test fail is from something else (see #685)

@devongovett devongovett merged commit 8d51fdc into parcel-bundler:master Jan 29, 2018
@devongovett
Copy link
Member

Thanks!

devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"HOT" module API is not standard
3 participants