Fix rust projects with hyphenated names #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
==========================================
- Coverage 88.82% 88.61% -0.22%
==========================================
Files 61 61
Lines 1897 1897
==========================================
- Hits 1685 1681 -4
- Misses 212 216 +4
Continue to review full report at Codecov.
|
brandon93s
approved these changes
Jan 25, 2018
devongovett
reviewed
Jan 26, 2018
src/assets/RustAsset.js
Outdated
| @@ -153,7 +153,8 @@ class RustAsset extends Asset { | |||
|
|
|||
| // Get output file paths | |||
| let outDir = path.join(cargoDir, 'target', RUST_TARGET, 'release'); | |||
| let rustName = cargoConfig.package.name; | |||
| // Rust converts '-' to '_' when outputting files. | |||
| let rustName = cargoConfig.package.name.replace('-', '_'); | |||
There was a problem hiding this comment.
This will only replace the first dash. We should make sure to replace every instance.
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Fix rust projects with hyphenated names * Update RustAsset.js
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Fix rust projects with hyphenated names * Update RustAsset.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, parcel will not successfully bundle rust code if the cargo project name has a hyphen in it. This PR fixes this bug.
In Rust, hyphens in project names are converted to underscores both in code and in output file names.