Add url dependency for serviceWorker.register calls #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
requested changes
Dec 26, 2017
src/visitors/dependencies.js
Outdated
| callee.object !== undefined && | ||
| callee.object.property !== undefined && | ||
| callee.object.property.name === 'serviceWorker' && | ||
| types.isStringLiteral(args[0]); |
There was a problem hiding this comment.
this is getting a bit unwieldy. maybe we could extract the matchesPattern helper from here and use that?
const isRegisterServiceWorker = matchesPattern(callee, 'navigator.serviceWorker.register');| if (isRegisterServiceWorker) { | ||
| let assetPath = asset.addURLDependency(args[0].value); | ||
| if (!isURL(assetPath)) { | ||
| assetPath = urlJoin(asset.options.publicURL, assetPath); |
There was a problem hiding this comment.
maybe we should just make addURLDependency include the publicURL?
There was a problem hiding this comment.
not sure- CSSAsset, LESSAsset, SASSAsset and StylusAsset use addURLDependency's return value without prefixing with the public url. Will prefixing with the public url by default cause problems in these asset types?
devongovett
approved these changes
Dec 29, 2017
Closed
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Add url dependency for serviceWorker.register calls * extract matchesPattern helper * sync SW regexp with matchesPattern arg
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* Add url dependency for serviceWorker.register calls * extract matchesPattern helper * sync SW regexp with matchesPattern arg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
serviceWorker.register('foo.js').Maybe we should support
self.importScripts('foo.js', 'bar.js', ...);too?